olivernn / lunr.js

A bit like Solr, but much smaller and not as bright
http://lunrjs.com
MIT License
8.89k stars 545 forks source link

Adds eslint settings to ignore mocha/chai #357

Open AndrewO opened 6 years ago

AndrewO commented 6 years ago

Red squiggles for test, suite, and assert all go away in VS Code + ESLint plugin with these changes.

AndrewO commented 6 years ago

I didn't change anything in the test that's breaking now... any idea why the build failed?

AndrewO commented 6 years ago

The breaking test is unrelated. The lunr.js that's checked into master is not the most up-to-date one. make clean && make regenerates it and passes.

olivernn commented 6 years ago

Yeah, the current build system has a few warts.

What exactly does this change do? Suppress warnings about mocha/chai related globals?

AndrewO commented 6 years ago

Yeah. It also reported a typo in some comments on lunrjs and com (guessing it tokenized on .).