Minified CDN version 2.3.8 is actually version 2.3.7

olivernn / lunr.js

A bit like Solr, but much smaller and not as bright

http://lunrjs.com

MIT License

8.94k stars 548 forks source link

Minified CDN version 2.3.8 is actually version 2.3.7 #460

Open Griatch opened 4 years ago

Griatch commented 4 years ago

Not sure if this is the correct place to report this ... but cdnjs.com has the wrong version of the minified lunr; it's listed as 2.3.8, but the version string inside is 2.3.7. This causes issues with third-party libraries that create index files for a specific lunr version.

https://cdnjs.cloudflare.com/ajax/libs/lunr.js/2.3.8/lunr.min.js is actually 2.3.7
https://cdnjs.cloudflare.com/ajax/libs/lunr.js/2.3.8/lunr.js appears to be the correct version

simonwiles commented 4 years ago

Same issue with unpkg.com (https://unpkg.com/lunr@2.3.8/lunr.min.js).

simonwiles commented 4 years ago

So after taking a closer look, it seems the package in NPM is broken, so cdnjs and unpkg and anyone else using the lunr.min.js from the NPM package will have the wrong version.

I was able to checkout the source code and build v2.3.8 of lunr.min.js successfully, however, so I guess it was just a manual packaging error? Hopefully it can be fixed by a package maintainer? @olivernn, are you the only person who can do this? Thanks!

simonwiles commented 4 years ago

The release of lunr v2.3.9 has been done correctly, fwiw, so this is more of a legacy issue at this point. It should probably still be fixed, though!