search

olivernn / poirot

mustaches in your rails
http://olivernn.github.com/poirot
108 stars 21 forks source link

Adding a method to manually reload templates #26

Closed maxschmeling closed 8 years ago

maxschmeling commented 11 years ago

I added a grabTemplates method to the poirot javascript object which allows you to manually grab new templates. It doesn't clear existing templates though.

This is because I am using turbolinks and the poirot object only knew about the templates on the first page I loaded.

olivernn commented 11 years ago

Thanks, this looks good. I made a couple of comments on the pull request, I'm happy to include this in the next release if you make those changes.

maxschmeling commented 11 years ago

I made the changes except for the "if (methodName in poirot)" check. I've got some more things I might add... when will you do the next release just so I know when I should get them in by?

olivernn commented 11 years ago

There are a couple of things I want to do also, and for once I actually have some time off client work for open source so I'm aiming for a new release in about a week. I'll drop you a note before I do though in case there is something else you were working on that is worth putting in the next release.

About the methodName in poirot check, perhaps your right, we can leave it out for now since it is a bit of an optimisation.