oliversalzburg / i18n-node-angular

An approach to utilize i18n-node in an AngularJS application
MIT License
38 stars 10 forks source link

Implicit jQuery requirement #6

Closed tkaufman closed 10 years ago

tkaufman commented 10 years ago

You may just want to document that there is an implicit requirement to have jQuery included before angular as the jqlite doesn't support selectors like

angular.element("body")

as is found in i18n-node-angular.js:42

Thanks, Todd

oliversalzburg commented 10 years ago

I thought tag names were supported? I admit, I haven't tested it without jQuery, but I'll look into other options if this is true.

tkaufman commented 10 years ago

I think they should be, but unfortunately it doesn't seem so.

oliversalzburg commented 10 years ago

I can definitely see the problem now. I'll hopefully release a version without the jQuery dependency soon. Thanks for the heads-up

oliversalzburg commented 10 years ago

I'm currently working on the new version which will remove the dependency on jQuery and enable a few other features. You can have a look at https://github.com/oliversalzburg/i18n-node-angular/tree/devel if you want to.