search

oliverschwendener / ueli

Cross-Platform Keystroke Launcher
https://ueli.app
MIT License
3.62k stars 239 forks source link

Feature: Linux support for Application Search #1073

Closed ke1v closed 6 months ago

ke1v commented 6 months ago

Ported over the previous attempt to add Linux support into the v9 codebase

Currently it's broken due to the usage of extract-file-icon, which doesn't support Linux. I haven't modified FileImageGenerator since it is a core dependency. How should I approach integrating Linux support into the application?

oliverschwendener commented 6 months ago

Thanks alot for your contribution! Currently I'm working on the removal of extract-file-icon as it was not really stable on Windows and not working on Linux at all. After extract-file-icon was removed we can look at merging this PR. I'll keep you posted.

Edit: see progress here: #1075

oliverschwendener commented 6 months ago

extract-file-icon is now removed. You can merge main back into your branch.

ke1v commented 6 months ago

Force push was an accident. Misclicked and Github apparently does not have a confirmation screen when force-pulling from upstream. I can't seem to reopen the pull request after reverting the push either.

oliverschwendener commented 6 months ago

Can you open a new PR?

oliverschwendener commented 6 months ago

@ke1v By the way I started to add some of your changes into my main branch separately, so that we can open a PR which is purely for adding the linux support in the ApplicationSearch extension.

See here: https://github.com/oliverschwendener/ueli/commit/6d8a2d335ddd198fd3ac45e0ad6516896a5151d4 and here: https://github.com/oliverschwendener/ueli/commit/78ae5dba1c5afcb207b2e98648537bf27d9521cd

oliverschwendener commented 6 months ago

@ke1v And for the ini file parser I created a generic utility that can be used by the ApplicationSearch extension: #1077

Would you mind helping me with that?