Fix(FileImageGenerator): remove `extrac-file-icon` dependency - Githubissues

oliverschwendener / ueli

Cross-Platform Keystroke Launcher

https://ueli.app

MIT License

3.46k stars 228 forks source link

Fix(FileImageGenerator): remove `extrac-file-icon` dependency #1075

Closed oliverschwendener closed 3 months ago

oliverschwendener commented 3 months ago

This PR serves the objective of getting rid of the extract-file-icon depedency for the following reasons:

It was unreliable on Windows
Did not work on Linux at all

Outstanding work:

[x] Remove extrac-file-icon dependency
[x] Use app.getFileIcon to generate icons
[x] Add icon extractors for apps on
- [x] macOS
- [x] Windows
[x] Add custom icon generation for folders on
- [x] macOS
- [x] Windows