feat(Application Search): Linux Support

[ke1v]

Reopening #1073

[ke1v]

Progress update - Extension is functional, but is still:

• Missing flatpak apps
• Packaging for Linux platforms fail. Running the either packages give the runtime error error: Cannot find module '@babel/runtime/helpers/interopRequireDefault' or doesn't render
• Need to write tests for new functionality

Working Screenshot (ran using pnpm dev)j:

Attempt to package (ran executable from pnpm package):

[oliverschwendener]

Thanks for the update and your efforts, i'll have a look when i'm back from vacation. The failing build is expected, you have to install the pnpm dependencies under the correct configuration (see release.yml where it says "configure pnpm").

[oliverschwendener]

To fix the Cannot find module '@babel/runtime/helpers/interopRequireDefault' error, you have to run these commands before running pnpm package:

pnpm config set shamefully-hoist true --location=project
pnpm config set auto-install-peers true --location=project
pnpm config set strict-peer-dependencies true --location=project

[oliverschwendener]

Can you update your branch, so that the changes that already have been added in my main branch disappear from this PR?

[ke1v]

Apologies for the messy commits, I'm still learning git. The plugin seems to be fully functional in GNOME and should be good to merge, but I don't have time currently to test out the other popular desktops for Linux.

[oliverschwendener]

FYI: I addressed all my feedback in this branch.

[oliverschwendener]

I tested it on Ubuntu Cinnamon, but none of the applications worked as the icons couldn't be found/generated. I suggest to fall back to a generic app icon when the icon generation fails.

Edit: I'll post logs later.

[ke1v]

I've also experienced this issue and am working on a fix to this and other bugs. I'm also planning to add support for more desktop environments than Cinnamon and GNOME, should I create a type similar to OperatingSystems with all supported Linux environments?

[oliverschwendener]

Yes you can, but let's keep in in the ApplicationSearch folder for now, as we only need it there now.

[ke1v]

I've changed the way applications get launched and it now supports launching files located anywhere on GNOME. I still have other desktops to test out (sorry spinning up VMs take a lot of time) which are all currently listed in LaunchDesktopFileActionHandler.ts

[oliverschwendener]

I tested it on Ubuntu Cinnamon and it works fine, although some icons couldn't be generated. There is a lot of opportunity for improvements, for example splitting code into multiple classes, simplifying code flows or adding more tests, but this is good enough for now, so let's merge it to move forward. Thanks alot for your time and all your efforts, much appreciated! 💪

For future changes please keep in mind:

• Make sure you set up commit signing, as it will be required for future contributions
• Add unit tests for every class or function from the beginning. It's often times harder to add them later on. I also had to learn this lesson 😅
• Use import type ... whenever possible
• Use accurate variable names, for example:

  // instead of this
  const processEnv: EnvironmentVariableProvider = ...

  // do this
  const envrionmentVariableProvider: EnvironmentVariableProvider ...

• Try to keep your code tidy and organized :) In this PR I added a lot of line breaks to make code blocks more separated from each other, so it's easier to read. This is a good example: https://github.com/oliverschwendener/ueli/pull/1078/commits/4d7dbaae4df92561dd32b0b733d8e6456414e7ba

I added you to the code owners of all the Linux parts of the ApplicationSearch extension, so I will forward all future feature request, issues and contributions to you for review, if that's fine. Keep it up!