search

oliverschwendener / ueli

Cross-Platform Keystroke Launcher
https://ueli.app
MIT License
3.62k stars 239 forks source link

Added test to cover `\r\n` line endings #1087

Closed oliverschwendener closed 5 months ago

oliverschwendener commented 5 months ago

This PR should add a fix to the IniFileParser in order to handle \r\n line endings correctly.

oliverschwendener commented 5 months ago

Hey @ke1v, I run into an issue when trying to parse an ini file from Mozilla Firefox (in order to support Firefox bookmarks). This specific ini file from Firefox on Windows has \r\n line endings, and the IniFileParser throws an error falsely. As you created the IniFileParser, could you look into the issue? I created a test in this branch, that demonstrates the issue.

ke1v commented 5 months ago

Yeah I can look into the issue. I've got a bunch of school work right now but I should have time later this week to fix it.

ke1v commented 5 months ago

@oliverschwendener I've fixed the issue but I don't have write access to the IniFileParser module

oliverschwendener commented 5 months ago

Can you create a PR from your fork that targets this branch? I wanted to invite you as a collaborator, but had to revoke it again because I realized that all collaborators have access to repository secrets that are used in GitHub Actions, for example for the deployment.

oliverschwendener commented 5 months ago

You can also target the main branch directly if you include a test, similar to the test that I added in this branch.