[Feature Request] V9, Alt+` and other key codes no longer supported from V8.

[IsaacKuri]

I was reading the documentation at https://www.electronjs.org/docs/latest/api/accelerator , and it seems like ` should be supported it is listed on the available key codes. But when I try to bind it, I get the following validation error.

Preview

I downgraded to V8 and verified that it is indeed possible to use this key combination but then again, looking at the change log V9 is a rewrite.

V8

Upon reading the source code, I see that there is a selection of key codes that are allowed. Would it be possible to add more key codes to the validations? ` is very handy since it rarely conflicts with games and applications.

Other good keys to support could be: , , ., /, ',[, ], \.

src/common/Core/Hotkey.ts

const isValidKeyCode = (keyCode: string): boolean => {
    const validators = [
        (keyCode: string) => /^[0-9]{1}$/.test(keyCode), // 0-9
        (keyCode: string) => /^[a-zA-Z]{1}$/.test(keyCode), // a-z, A-Z
        (keyCode: string) => /^(F[1-9]|F1[0-9]|F2[0-4])$/.test(keyCode), // F1-F24
        (keyCode: string) => /^num[0-9]{1}$/.test(keyCode), // num0-num9
        (keyCode: string) =>
            /^(Plus|Space|Tab|Capslock|Numlock|Scrolllock|Backspace|Delete|Insert|Return|Up|Down|Left|Right|Home|End|PageUp|PageDown|Escape|VolumeUp|VolumeDown|VolumeMute|MediaNextTrack|MediaPreviousTrack|MediaStop|MediaPlayPause|PrintScreen)$/.test(
                keyCode,
            ),
    ];

    return validators.some((validator) => validator(keyCode));
};

const isValidModifier = (modifier: string): boolean =>
    /^(Command|Cmd|Control|Ctrl|CommandOrControl|CmdOrCtrl|Alt|Option|AltGr|Shift|Super|Meta)$/.test(modifier);

/**
 * Checks if the given string is a valid hotkey.
 * A valid hotkey is a combination of a modifier and a key code, e.g. `CmdOrCtrl+Space`. For more information, see
 * https://www.electronjs.org/docs/api/accelerator.
 * @param hotkey The hotkey to check, e.g. `CmdOrCtrl+Space`.
 * @returns `true` if the hotkey is valid, otherwise `false`.
 */
export const isValidHotkey = (hotkey: string) => {
    const parts = hotkey.split("+");
    const hasModifier = parts.length > 1;
    const keyCode = hasModifier ? parts[1] : parts[0];
    const modifier = hasModifier ? parts[0] : undefined;

    return isValidKeyCode(keyCode) && (modifier ? isValidModifier(modifier) : true);
};

[oliverschwendener]

Thanks for your feedback. This should be fixed with the next release.