search

oliverschwendener / ueli

Cross-Platform Keystroke Launcher
https://ueli.app
MIT License
3.66k stars 242 forks source link

Performance Improvement #1155

Closed IrishBruse closed 3 months ago

IrishBruse commented 3 months ago

The application would lag alot while scrolling up and down quickly I found the cause to be the contextBridge I also added an option to improve the responsiveness of the scrolling with an option.

Before: image

After: image

oliverschwendener commented 3 months ago

Thank you for your contribution! Your solution seems to work very nicely. As I'm a react rookie I'm very happy to see such improvements. I left some comments about translations and naming consistency.

IrishBruse commented 3 months ago

Should be everything fixed now thanks for all the feedback I appreciate it

oliverschwendener commented 3 months ago

Unfortunately, some of your commits are not signed. Can you please make sure they're signed?

IrishBruse commented 3 months ago

Sorry about that should be good to go now not done much with signed commits before ill go fix my other pr too

IrishBruse commented 3 months ago

🥳

oliverschwendener commented 3 months ago

Nice work, thank you for taking your time!