Add navigation with C-n and C-p

[sashaweiss]

Hi! Excited to start using Ueli v9. I was missing navigating using Ctrl-n and Ctrl-p, so I made a change to add event handlers for those keys to the existing list of event handlers in Search that already listen for arrow keys.

Please let me know what you think.

[oliverschwendener]

Hey Sasha, good to have you back! :) Can you explain why Ctrl+N/Ctrl+P?

[sashaweiss]

Whoops, sorry – replied from my work account. Reposting my comment:

In my experience, Ctrl-n and Ctrl-p are pretty common as "next" and "previous" commands in vim-based keymaps! For example, in vim itself you can use Ctrl-n and Ctrl-p to move through autocompletion options. I use a lot of vim-based keymaps, so I've gotten used to using them where available.

These worked in ueli v8, so my hope was that we'd be ok including them in v9 as well.

[oliverschwendener]

I was wondering if there is a way to make this more customizable. Some people just need arrow up/arrow down, some enjoy using Ctrl+n/Ctrl+p, other might have even other preferences.

[oliverschwendener]

Maybe a dedicated "Keyboard shortcuts" section somewhere in the settings would make sense, where all the keyboard shortcuts can be customized.

[oliverschwendener]

Thanks for your efforts!

I'll accept this addition, but we need more sophisticated solution in the future, as mentioned above.

[oliverschwendener]

Can you sign your commits?

[oliverschwendener]

Closing this due to inactivity. Feel free to reopen, make sure to sign your commits though ;)

[sashaweiss]

Hey @oliverschwendener – sorry for the inactivity. Had a productive evening, but since then been a busy summer :) I'll circle back and reopen, with updated (signed) commits. Thanks for your patience!