search

oliverschwendener / ueli

Cross-Platform Keystroke Launcher
https://ueli.app
MIT License
3.62k stars 239 forks source link

fix(ApplicationSearch): Add support for more desktop environments #1159

Closed ke1v closed 3 weeks ago

ke1v commented 1 month ago

Fixes #1154, adds support for KDE, MATE, XFCE, and Pantheon desktops

Also includes fix for small bug in IniFileParser

oliverschwendener commented 1 month ago

I updated this branch now with the new LinuxDesktopEnvironmentResolver.

ke1v commented 4 weeks ago

@oliverschwendener Everything should be in working order now.

Some questions I have for further development/improvements:

  1. Should the tests cover every possible input? LinuxDesktopEnvironmentResolver.test.ts only tests for 4 different desktops as there are a dozen or two different strings to test for.
  2. LinuxApplicationRepository actually works on every Linux desktop, it's just the icon generation that needs individual desktop support. Should the plugin support all desktops and default to the fallback icon for the few desktops that don't have icon generation support?
oliverschwendener commented 4 weeks ago
  1. I hoped that you would complete the rest of the desktop environments in LinuxDesktopEnvironmentResolver.ts and LinuxDesktopEnvironmentResolver.test.ts.
  2. Yes, that's exactly what I would do.