search

oliverschwendener / ueli

Cross-Platform Keystroke Launcher
https://ueli.app
MIT License
3.62k stars 239 forks source link

Adds a setting for "max search results, when the search term is empty" #1161

Closed sashaweiss closed 4 weeks ago

sashaweiss commented 1 month ago

Adds a setting used to limit the max displayed search results, only when the search term is empty.

I appreciated the minimal, Spotlight-adjacent form factor of ueli in V8 (although V9 looks great!), and I don't often use the items in the first alphabetical page of search results that are shown when I launch ueli. I initially set out to entirely disable the initial page of search results, but as there was already a numerical setting for "max search results", I simply mirrored that setting and will plan to configure mine to be set to 0. It's a little awkward having the empty window for search results, but (1) I don't know enough React to mess with that :) and (2) it does reduce flicker, which is nice.

Please let me know if this is something you'd like to take, and if there are any stylistic or functional changes you'd like me to make.

Screenshots

maxSearchResultsEmptySearchTerm: 5 maxSearchResultsEmptySearchTerm: 0
image image
image
oliverschwendener commented 1 month ago

While I appreciate your efforts, I don't see a benefit in the proposed solution. If I understand you correctly, you would appreciate to have an option to collapse the window when no search term is given, for example like this:

image

And when you start typing, extend the window height as necessary, for example like this:

image

Is that correct?

oliverschwendener commented 4 weeks ago

As I don't see a value in this proposal I'll close this issue. Thanks for your efforts though :)

sashaweiss commented 3 weeks ago

Hey @oliverschwendener!

If I understand you correctly, you would appreciate to have an option to collapse the window when no search term is given ... ... And when you start typing, extend the window height as necessary ...

That's correct – my goal was to approximate that behavior without getting into the design complications that'd result. Apologies for the radio silence (been a busy summer), although I am planning to circle back to this change, and the others I opened! When I make the time, I'll look into a more complete solution involving dynamically sizing the results window.