oliverschwendener / ueli

Cross-Platform Keystroke Launcher
https://ueli.app
MIT License
3.66k stars 242 forks source link

:sparkles: Add option for setting a default target currency #1210

Closed peterphmikkelsen closed 1 month ago

peterphmikkelsen commented 2 months ago

Description

Hello (again)! I am back with the second round of default target currency! (I was the person who implemented this for the old version as well) 😅

Still love the app and still use it very frequently 🤘 So kudos! 🙏

Fixes #1207

:sparkles: Default Target Currency

I added the option for setting a default target currency. This includes updating the settings panel and a bit of the code to handle the input in the case of just writing the shorthand version.

The settings part let's the user pick only from the already selected list of currencies.

[!note] Note that I tried adding the Swiss German translation for the setting, but since I do not actually speak this language very well a quick review from someone who does would be appreciated 🙏

📷 How It Looks

image

📝 Notes

Couple of things of note:

oliverschwendener commented 1 month ago

Hey Peter, thanks for your efforts! :)

I just added some tests around the CurrencyConversion extension, so we can be sure that your addition works as expected and doesn't break the existing functionality. Please update your branch.