ASICBOOST Fix

[pool2mine]

Hello Oliver, I saw old issues about the ASICBOOST problem, i wanted to ask if you wanted to make the fix, i would like to get back to miningcore, but i need this working, i want to know if i can donate to the project, i don't want this as a private development, it's ok for me if you make the fix public for the repo, i think this is an amazing peace of software, i'm pretty sure with this fix it will be way more popular! let me know your thoughts. If you need to PM me, my telegram user is https://t.me/pool2minedev

Regards!

[goodthebest]

in fact, asicboost partially works, if you have a local asicboost enabled machine you can try to connect it would probably work, however with Nicehash asicboost it didn't work when I tested.

[Konstantin35]

Nice requires mandatory presence error

JsonRpcRequest.cs, JsonRpcResponse.cs

add

[JsonProperty("error")]
public JsonRpcError Error { get; set; }

you also need to change this line https://github.com/oliverw/miningcore/blob/master/src/Miningcore/JsonRpc/JsonRpcResponse.cs#L53 otherwise if the error is null it is not there

[goodthebest]

@Konstantin35

you also need to change this line https://github.com/oliverw/miningcore/blob/master/src/Miningcore/JsonRpc/JsonRpcResponse.cs#L53 otherwise if the error is null it is not there

This line....

[JsonProperty(PropertyName = "error", NullValueHandling = NullValueHandling.Ignore)]

To be replaced with the line exactly?

[JsonProperty("error")]