oliverw / miningcore

Miningcore is a high-performance Mining Pool Software for Linux and Windows.
https://store.miningcore.pro
MIT License
730 stars 674 forks source link

new blocks rejected zcash #281

Closed be4i closed 6 years ago

be4i commented 6 years ago

Hello, i am trying the software on the test network of zcash, but when i found new block and the pool tries to submitted it gets rejected with reason: "tx-overwinter-active".

Using release-21 on windows 10 x64

    "logging": {
        "level": "info",
        "enableConsoleLog": true,
        "enableConsoleColors": true,
        "logFile": "",
        "logBaseDirectory": "",
        "perPoolLogFile": false
    },
    "banning": {
        "manager": "integrated",
        "banOnJunkReceive": true,
        "banOnInvalidShares": false
    },
    "notifications": {
        "enabled": false,
        "email": {
            "host": "smtp.example.com",
            "port": 587,
            "user": "user",
            "password": "password",
            "fromAddress": "info@yourpool.org",
            "fromName": "support"
        },
        "admin": {
            "enabled": false,
            "emailAddress": "user@example.com",
            "notifyBlockFound": true
        }
    },
    "persistence": {
        "postgres": {
            "host": "xxx.xxx.xxx.xxx",
            "port": 5432,
            "user": "miningcore",
            "password": "123",
            "database": "miningcore"
        }
    },
    "equihashMaxThreads": 4,
    "paymentProcessing": {
        "enabled": false,
        "interval": 600,
        "shareRecoveryFile": "recovered-shares.txt"
    },
    "pools": [{
        "id": "zec1",
        "enabled": true,
        "coin": {
            "type": "ZEC"
        },
        "address": "tmVDqhmuzqZXP6Yzg8oxLeuhvT3Ywis8hQ8",
        "z-address": "ztcnsCv3stuYgVxhtuPPNRNvFAeJu1wsHxNqoMX9xHmuRUHTKXcbHeKwx9snXcKJ7m61886P2yZdosSYgV9n8a5fyqqmQi7",
        "rewardRecipients": [
            {
                "type": "op",
                "address": "tmYapfqasC2KNtRVtXDSBWmPmSW8YmEYxRt",
                "percentage": 1.5
            }
        ],
        "blockRefreshInterval": 500,
        "jobRebroadcastTimeout": 1111110,
        "clientConnectionTimeout": 600,
        "banning": {
            "enabled": true,
            "time": 600,
            "invalidPercent": 50,
            "checkThreshold": 50
        },
        "ports": {
            "3092": {
                "difficulty": 0.1,
                "varDiff": {
                    "minDiff": 0.01,
                    "maxDiff": null,
                    "targetTime": 15,
                    "retargetTime": 90,
                    "variancePercent": 30,
                    "maxDelta": 1
                }
            },
            "3093": {
                "difficulty": 1
            }
        },
        "daemons": [
            {
                "host": "xxx.xxx.xxx.xxx",
                "port": 18232,
                "user": "123",
                "password": "123"
            }
        ],
        "paymentProcessing": {
            "enabled": false,
            "minimumPayment": 0.01,
            "payoutScheme": "PPLNS",
            "payoutSchemeConfig": {
                "factor": 2.0
            }
        }
    }]
}
oliverw commented 6 years ago

@be4i That's strange. I've just tested it against my zcash-testnet node and was able to mine tons of blocks without any rejections.

be4i commented 6 years ago

@oliverw so must me something in my node configuration ?

zywoo commented 6 years ago

@be4i @oliverw I’ve tested against my zcash-testnet node and had mined lotst of blocks,but cathed the same exception of "tx-overwinter-active" yesterday. " image "

bitspill commented 6 years ago

I believe that's the Overwinter upgrade that's coming this summer (Block 207,500 on testnet) not being implemented in MiningCore yet

https://github.com/zcash/zcash/blob/master/doc/release-notes/release-notes-1.0.15.md https://z.cash/upgrade/overwinter.html https://blog.z.cash/overwinter/

oliverw commented 6 years ago

@bitspill Thanks for the links. I've spotted references to "overwinter" in the zcash codebase but missed the pages you've linked.

oliverw commented 6 years ago

@be4i @zywoo @bitspill Confirmed to be currently a testnet-exclusive problem that needs to be fixed before it turns into a production problem on mainnet. Hoping to fix tommorow.