search

oliverw / miningcore

Miningcore is a high-performance Mining Pool Software for Linux and Windows.
https://store.miningcore.pro
MIT License
727 stars 666 forks source link

randomx is not part of cryptonote family #846

Closed calvintam236 closed 3 years ago

calvintam236 commented 3 years ago

I think we need to split out randomx as a different coin family. This gives a framework for other contributors to support coins that are still using CN/RX and its variants. (Good list of variants from xmrig)

oliverw commented 3 years ago

A coin family is not just defined by the POW algo but rather the complete package consisting of POW, RPC interface to the daemon and Stratum Protocol.

calvintam236 commented 3 years ago

A coin family is not just defined by the POW algo but rather the complete package consisting of POW, RPC interface to the daemon and Stratum Protocol.

If this is the case, we should standardize the coin family name to be a base coin (e.g. Bitcoin includes BTC, LTC, BTG, DODG, etc, and Ethereum includes ETH, ETC, etc.). It could support any other coins that are hard-forked/ cloned from this base coin since they usually doesn’t change much on the RPC.

Cyrptonote should rename to Monero to avoid confusion (some use CN and some use RX). Not sure about Equihash. Maybe it should be Zcash?

lurchinms commented 3 years ago

RandomX is part of the CryptoNote family. Just needs to be updated. https://github.com/dvandal/cryptonote-nodejs-pool

oliverw commented 3 years ago

RandomX is part of the CryptoNote family. Just needs to be updated. https://github.com/dvandal/cryptonote-nodejs-pool

Already is.

MiningCryptoLive commented 3 years ago

Setup monero pool using miningcore and the example config and pool works but all hashes are rejected saying bad hash.

oliverw commented 3 years ago

The current release has been successfully tested with the latest Xmrig version and official Monero Testnet and Mainnet.

MiningCryptoLive commented 3 years ago

I just built the pool this morning. Monero mainnet node. Miner connects but all shares are rejected saying bad hash. Using the config from the example folder. Am I missing something? Git pull states I'm on the newest version.

On Tue, Jun 22, 2021, 7:53 AM Oliver Weichhold @.***> wrote:

The current release has been successfully tested with the latest Xmrig version and official Monero Testnet and Mainnet.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/coinfoundry/miningcore/issues/846#issuecomment-865917545, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIAKRQLEX27T43FUF7S6ULTUB2TFANCNFSM467XYKLA .

oliverw commented 3 years ago

Post the (redacted) pool log.

MiningCryptoLive commented 3 years ago

Post the (redacted) pool log.

I have never had to run a pool log on mining core. Trying to find out how. I will post when figured out

oliverw commented 3 years ago

Well it should log to the console by default

MiningCryptoLive commented 3 years ago

xmr.log

this is the log

oliverw commented 3 years ago

xmr.log

this is the log

Looks fine. How do you start your miner?

MiningCryptoLive commented 3 years ago

Xmrig using config. Should I try using the command line to start it

On Tue, Jun 22, 2021, 9:41 AM Oliver Weichhold @.***> wrote:

xmr.log https://github.com/coinfoundry/miningcore/files/6694611/xmr.log

this is the log

Looks fine. How do you start your miner?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/coinfoundry/miningcore/issues/846#issuecomment-865993942, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIAKRVR3QPXWS2ZM3LPRS3TUCHHBANCNFSM467XYKLA .

oliverw commented 3 years ago

Xmrig using config. Should I try using the command line to start it … On Tue, Jun 22, 2021, 9:41 AM Oliver Weichhold @.***> wrote: xmr.log https://github.com/coinfoundry/miningcore/files/6694611/xmr.log this is the log Looks fine. How do you start your miner? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#846 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIAKRVR3QPXWS2ZM3LPRS3TUCHHBANCNFSM467XYKLA .

Need the command line or config.

calvintam236 commented 3 years ago

Looks like it is getting off-topic here. Probably should be another issue.

calvintam236 commented 3 years ago

RandomX is part of the CryptoNote family. Just needs to be updated. https://github.com/dvandal/cryptonote-nodejs-pool

https://monero.stackexchange.com/a/11003 Randomx does not derived from Cryptonote. This is a separate algo.

A coin family is not just defined by the POW algo but rather the complete package consisting of POW, RPC interface to the daemon and Stratum Protocol.

If this is the case, we should standardize the coin family name to be a base coin (e.g. Bitcoin includes BTC, LTC, BTG, DODG, etc, and Ethereum includes ETH, ETC, etc.). It could support any other coins that are hard-forked/ cloned from this base coin since they usually doesn’t change much on the RPC.

Cyrptonote should rename to Monero to avoid confusion (some use CN and some use RX). Not sure about Equihash. Maybe it should be Zcash?

Coming back to this, should this change should be made?

MiningCryptoLive commented 3 years ago

This definitely needs to be fixed. Miningcore using the monero config does not work!! Supposedly it was tested which I doubt. All shares submitted with this get rejected as bad hash. RandomX is not part of cryptonote. It is its own variation.

calvintam236 commented 3 years ago

This definitely needs to be fixed. Miningcore using the monero config does not work!! Supposedly it was tested which I doubt. All shares submitted with this get rejected as bad hash. RandomX is not part of cryptonote. It is its own variation.

Please submit a separate issue for monero problem. Thanks..

oliverw commented 3 years ago

This definitely needs to be fixed. Miningcore using the monero config does not work!! Supposedly it was tested which I doubt. All shares submitted with this get rejected as bad hash. RandomX is not part of cryptonote. It is its own variation.

https://coinfoundry.org/pool/xmr is running the same code. Feel free to test your miner.

MiningCryptoLive commented 3 years ago

I used cryptonote-nodejs and it works fine. I will try building miningcore again tonight and see if I missed something.

oliverw commented 3 years ago

I doubt it has anything to do with the build.

MiningCryptoLive commented 3 years ago

If it has nothing to do with the build then it doesn't work! And the link you posted saying they use this code is incorrect. They merged from moneroocean and nodejs-pool for a working pool

On Thu, Jun 24, 2021, 5:14 PM Oliver Weichhold @.***> wrote:

I doubt it has anything to do with the build.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/coinfoundry/miningcore/issues/846#issuecomment-867956228, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIAKRV3DLYOUKHU23L2UL3TUON47ANCNFSM467XYKLA .

oliverw commented 3 years ago

If it has nothing to do with the build then it doesn't work! And the link you posted saying they use this code is incorrect. They merged from moneroocean and nodejs-pool for a working pool … On Thu, Jun 24, 2021, 5:14 PM Oliver Weichhold @.***> wrote: I doubt it has anything to do with the build. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#846 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIAKRV3DLYOUKHU23L2UL3TUON47ANCNFSM467XYKLA .

Please don't make me lose my temper. I've been the administrator of the site I linked forever. It's even linked on the top right of this repository.