search

oliveryh / obsidian-emoji-toolbar

An Obsidian plugin to quickly add emojis into your notes
BSD 3-Clause "New" or "Revised" License
200 stars 10 forks source link

[BUG] Emoji is inserted at the very start of the doc, not where the cursor currently is #39

Closed tingmelvin closed 1 year ago

tingmelvin commented 1 year ago

As stated in the title: Expected behaviour: emoji is inserted where the cursor is, like how typing works Current behaviour: emoji is inserted at the very start of the document.

I'm getting this as well in the inspector/debugger:

plugin:obsidian-emoji-toolbar:722 Warning: Failed prop type: The prop `emoji` is marked as required in `Preview`, but its value is `null`.
    at Preview (plugin:obsidian-emoji-toolbar:62352:37)
    at NimblePicker (plugin:obsidian-emoji-toolbar:62868:37)
    at div
    at EmojiToolbar (plugin:obsidian-emoji-toolbar:104169:9)
oliveryh commented 1 year ago

Hi @tingmelvin , do you mind letting me know what your OS version and Obsidian version is so I can try to reproduce this myself?

tingmelvin commented 1 year ago

Hi! On mobile rn, but I'm on Obsidian 0.16.3, and on Windows 11

johackim commented 1 year ago

I have this bug too on Arch Linux with Obsidian 0.16.3

oliveryh commented 1 year ago

Thanks for the additional bug report and info. I'll likely get time to investigate at the weekend.

oliveryh commented 1 year ago

I should have a short-term fix that at least addresses this in Obsidian v0.16.3.

I'm planning to include it in the v0.3.2 release tomorrow.

oliveryh commented 1 year ago

Please update to v0.3.2. I'll probably report to the Obsidian devs that the cursor momentarily jumps to the start of the document when closing a modal but this release should address the immediate issue.

johackim commented 1 year ago

Awesome thanks !