oliveryh / obsidian-emoji-toolbar

An Obsidian plugin to quickly add emojis into your notes
BSD 3-Clause "New" or "Revised" License
200 stars 10 forks source link

Offline support #7

Closed oliveryh closed 1 year ago

oliveryh commented 3 years ago

Message from Licat:

I'd also like to add that Obsidian is designed to be an offline app, so plugins/themes are generally expected to work offline just as well as online, unless your plugin requires the use of networking (like sync or something) Your plugin/theme wouldn't deliver a great experience if it looks the different when the user go without internet, or has a spotty connection

Therefore it might be best to detect if offline and then default to not use twitter / online emojis or load them into the local filesystem when online.

bikingbadger commented 3 years ago

Is this not already the case. The emoji's are loaded as part of the package so they're already in the file. I don't think it downloads the JSON file again.