oliviakumar / vmware_edgewalk

CS490 Senior Team Project, VMware IoT
1 stars 1 forks source link

Fix absolute paths from calls to file system #22

Open TanjaNuendel opened 4 years ago

TanjaNuendel commented 4 years ago

Proposed change### Why it’s important

e.g. in gofacedevice.go the path has to be absolute for it to work, we should change it to relative though to make it as portable as possible

No idea what is wrong tho - needs research into Go file calls (os.Open etc.)

mkbhanda commented 4 years ago

A container starts up in the directory it’s executable is in. So to be truly agnostic of that it makes sense to have an absolute path. And that is relative to the container root file system. With namespace isolation different containers can specify the exact same path.


Sent from Workspace ONE Boxerhttps://whatisworkspaceone.com/boxer

On November 4, 2019 at 2:14:09 PM MST, TanjaNuendel notifications@github.com wrote: Proposed change### Why it’s important

e.g. in gofacedevice.go the path has to be absolute for it to work, we should change it to relative though to make it as portable as possible

No idea what is wrong tho - needs research into Go file calls (os.Open etc.)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foliviakumar%2Fvmware_edgewalk%2Fissues%2F22%3Femail_source%3Dnotifications%26email_token%3DAAUTXVNBBE7VGTY32HDTLUTQSCGB5A5CNFSM4JIZY7E2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HWW72TA&data=02%7C01%7Cmbhandaru%40vmware.com%7Ca0e0cb87a87041b877d608d7616bedb6%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637084988485579210&sdata=zLRhxUVsoTq9CPx1imo%2BKPtSc9QsUR7xnPCUfWHia0w%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAUTXVJ3ISKFFW3K3R5JU7TQSCGB5ANCNFSM4JIZY7EQ&data=02%7C01%7Cmbhandaru%40vmware.com%7Ca0e0cb87a87041b877d608d7616bedb6%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637084988485589202&sdata=syvOLb0Z%2FKaqejuA1dX107U%2FRDC4uahTXviVLKbRato%3D&reserved=0.