search

oliviercailloux / decision-uta-method

A repository containing the doc and the work done during my research about UTA method.
MIT License
0 stars 0 forks source link

External arguer #10

Closed oliviercailloux closed 5 years ago

oliviercailloux commented 6 years ago

move argue logic out of Model, as discussed

tonyseg commented 6 years ago

Done.

oliviercailloux commented 6 years ago

This is not exactly as discussed. Ok to simplify it, though. But the current argue is too complex, and the logic is unclear as possible usage depends on how the class has been initialized.

Please provide methods argueIVT(IVTOutput output), argueRMGAVG(RMGAVTOutput), … and argue(LabreucheOutput) which delegates to the right method using a switch.

tonyseg commented 6 years ago

Done.

oliviercailloux commented 6 years ago

Nice. Please call it LabreucheArguer (move it to the corresponding package) and create another NunesArguer for Nunes model.

tonyseg commented 6 years ago

Done.

oliviercailloux commented 6 years ago

LabreucheArguer should be in package, well, labreuche. (Similarly for Nunes.) The method should not return a string to indicate an error, it should fail fast and in a detectable way by throwing an exception. It should be an IllegalStateException in case of an impossible default case in a switch (in LabreucheArguer) and an UnsupportedOperationException in case of not yet implemented part functionality (in NunesArguer).

tonyseg commented 6 years ago

Migration on the right package and IllegalStateException throwing in default case.

tonyseg commented 6 years ago

Done