olivierdalang / VectorBender

VectorBender is a QGis plugin
GNU General Public License v3.0
37 stars 15 forks source link

Update vectorbender.py #29

Closed busterbeam closed 3 years ago

busterbeam commented 3 years ago

I have run NO tests. improved variable naming, changed iterative step to use recursion to reconstruct lists with transform, instead of having varying but repetitive code. Simplified feature counting as a separate function and reduced if statements where any count < 4 just returns it's feature count and anything above 3 considered it's dependency status.

unload could probably be improved if dialog is a sub classed from _io module and just check that the file is closed, assigning None to it is a bit pointless, removed u prefix from strings as that is an old Unicode thing from python 2. Python 3 supports Unicode full stop


also setValue doesn't PyQt support floats so you can get a more fine grain loading bar

olivierdalang commented 3 years ago

Closing as this looks suspicious to me, if it's a legit PR please explain what you're trying to achieve and group all related changes under one PR