search

olivierdalang / VectorBender

VectorBender is a QGis plugin
GNU General Public License v3.0
37 stars 15 forks source link

Update vectorbendertransformers.py #30

Closed busterbeam closed 3 years ago

busterbeam commented 3 years ago

Added three base methods to Transformer object, one of which is pythag using math for both power pow and sqrt for speed and accuracy. improved variable names where possible, added more white-space in arithmetic expressions for improved readability, or changed to methods e.g. pythag for improved readability. Added _scale and _rotation methods to LinearTransformer to improve readability, and extensibility

I strongly believe AffineTransformer object initialization can be improved. using loops and lists to instead compute the new affine position and shape of vector.

Again I have not tested any of the changes.. I am unable to setup this up for my machine at the present moment

olivierdalang commented 3 years ago

Closing as this looks suspicious to me, if it's a legit PR please explain what you're trying to achieve and group all related changes under one PR