olivierfriard / BORIS

Behavioral Observation Research Interactive Software
http://www.boris.unito.it
GNU General Public License v3.0
174 stars 34 forks source link

Key codes don't work for multiple selection modifiers #160

Closed rorymichele closed 6 years ago

rorymichele commented 6 years ago

If a modifier set is multiple selection type, the values can not be selected by key code. Even worse, when it is the only set, the dialog will close without selecting anything. I added a small patch (only for qt5), but it creates unwanted (visible, not data wise) effects for ethograms with behaviours that need multiple sets of single selection, as I simply always set the Qt.Checked state. I could not find a way to access the information whether it is a multiple or single selection modifier at this point in the code without major changes, therefore this insufficient solution. select_modifiers.py.zip Again, this is against version 6.3.5.

olivierfriard commented 6 years ago

Hello, Thank you for the suggestion. I modified the select_modifiers.py file (only in the mp branch / v.7) and it is working now. Should work also for the v.6. Please Test the attached file and let me know.

On Thu, Sep 27, 2018 at 6:12 PM rorymichele notifications@github.com wrote:

If a modifier set is multiple selection type, the values can not be selected by key code. Even worse, when it is the only set, the dialog will close without selecting anything. I added a small patch (only for qt5), but it creates unwanted (visible, not data wise) effects for ethograms with behaviours that need multiple sets of single selection, as I simply always set the Qt.Checked state. I could not find a way to access the information whether it is a multiple or single selection modifier at this point in the code without major changes, therefore this insufficient solution. select_modifiers.py.zip https://github.com/olivierfriard/BORIS/files/2424882/select_modifiers.py.zip Again, this is against version 6.3.5.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/olivierfriard/BORIS/issues/160, or mute the thread https://github.com/notifications/unsubscribe-auth/AGOgYjH-QQjEojvAAwbtOiyMW6nC0x4Cks5ufPjkgaJpZM4W8_2r .

-- University of Torino Life Sciences and Systems Biology department Via dell'Accademia Albertina, 13 10123 TORINO (Italy) tel: +39 011 6704542 http://www.di.unito.it/~friard/ http://orcid.org/0000-0002-0374-9872

rorymichele commented 6 years ago

great! works like charm also for v.6. thank you!