olivierfriard / BORIS

Behavioral Observation Research Interactive Software
http://www.boris.unito.it
GNU General Public License v3.0
170 stars 34 forks source link

measurements #677

Open Philippe-s-Levi opened 10 months ago

Philippe-s-Levi commented 10 months ago

windows 10 ... boris 8.21.8

when I choose a measurement and a color, then draw it on the player, it is correctly designed, using the selected color.

playing the video, the color changes always to red.

taking advantage ... Boris let inform incomplete measurement. Start drawing an angle (left button, right button) then continue starting another new angle (left button ...) ... the first one continue on the image ... just disappears when playing the video. It may be deleted as a new one begins to be drawn. Or the user may be awared of the situation. Or ???

Philippe-s-Levi commented 10 months ago

from geometric_measurement.py

line 865 and next for element in self.measurement_w.draw_mem[frame]: if frame == current_frame: elements_color = element["color"] else: elements_color = cfg.PASSIVE_MEASUREMENTS_COLOR

this last line is the reason why selected color is not used when viewing the video (frame != current_frame)

I don't imagine the reason of the test on current_frame ...

when I change cfg.PASSIVE_MEASUREMENTS_COLOR to element["color"] it is working as expected (by me at least! :) ) , using the selected color ...