oliviergauthier / gradle-appcenter-plugin

This gradle plugin allow you to upload each build variant of your android application to separate AppCenter Apps.
MIT License
84 stars 44 forks source link

Set a higher write-timeout for larger files. #11

Closed Panzenbaby closed 5 years ago

Panzenbaby commented 5 years ago

I already increased the timeouts for read and connect in a previous pr. But I recognized that I changed the wrong timeouts and a upload of big files could still cause a SocketTimeOutException if the bandwidth is limited. E.g. if you have a bandwidth of 1mb/s you wouldn't be able to write files larger than 10MB (the default timeout for writing is 10 seconds). I read that app center has a limit of 4GB for app files. So maybe you should consider to add a parameter to the extension to control the timeouts and support really big files.

oliviergauthier commented 5 years ago

hi, i have added some environnent variables in the last release.

Panzenbaby commented 5 years ago

Thank you. Are you sure to use environment variables names with a dot? I'm using a Mac and can't use dots in the variable name.

If I try export http.timeout.write=60

I get an error: 'http.timeout.write': not a valid identifier

So maybe it's better to use underlines instead of dots. export http_timeout_write=60

oliviergauthier commented 5 years ago

@Panzenbaby I, i have changed environment variables with '_' instead of dot, but you can now use gradle properties to set timeouts