search

oliviergauthier / gradle-appcenter-plugin

This gradle plugin allow you to upload each build variant of your android application to separate AppCenter Apps.
MIT License
84 stars 44 forks source link

Added printing releaseUrl feature #37

Closed konstzv closed 4 years ago

konstzv commented 4 years ago

Added possibility to enable/disable printing releaseUrl of uploaded application

oliviergauthier commented 4 years ago

Do you really need to hide this url ? Why not always show it at the end of the upload ? Is it only for debug or you use it in your build process ?

konstzv commented 4 years ago

Do you really need to hide this url ? Why not always show it at the end of the upload ? Is it only for debug or you use it in your build process ?

Thank you for the quick response. I don't get it a little bit. In my case, users build application on their personal computers and and they want get a link when the download is successful. Do you doubt that feature should be disabled by default? I can change the initial state to enabled(true) - it's even more convenient for me. I disabled it by default because I thought it can interfere with someone. Or you do you think feature should be enabled always and we don't need flag to control it? That's fine with me, just wanted to make it more flexible. Let me know which option is better - I will make changes.

oliviergauthier commented 4 years ago

I think we can always print url and wait for someone asks to hide it :-)

konstzv commented 4 years ago

I think we can always print url and wait for someone asks to hide it :-)

Ok) I removed flags

konstzv commented 4 years ago

@oliviergauthier is it ok? Can you merge it?