olivierjeunen / ease-side-info-recsys-2020

Source code for our LBR paper "Closed-Form Models for Collaborative Filtering with Side-Information" published at RecSys 2020.
MIT License
14 stars 3 forks source link

There is no `train_val_test_split_Jebara` function in util.py #1

Open aporia3517 opened 3 years ago

aporia3517 commented 3 years ago

Hi @olivierjeunen, thanks for sharing your awesome work.

In the preprocessing codes, there are some functions like util.train_val_test_split_Jebara and util.train_val_test_split_Karypis, but I cannot find these in util.py.

olivierjeunen commented 3 years ago

Hi @aporia3517 -- thanks for pointing this out, and my apologies for the delay in responding.

This is sloppy from my side -- but the functions you're looking for were renamed "train_val_test_split_strong" and "train_val_test_split_loocv" respectively, to denote "strong generalisation" and "LOOCV". It even seems another typo slipped in and the second function is currently defined as "train_val_test_split_loocb" in util.py.

I'll make sure to update the files and the repo, but might need a few days for this. Changing the function definitions or calls should work.

My apologies for the sloppiness again -- let me know if you'd have any other issues with getting things working.