olivierkes / manuskript

A open-source tool for writers
http://www.theologeek.ch/manuskript
GNU General Public License v3.0
1.71k stars 226 forks source link

Random segfault on Fedora 37 #1160

Open UltimaTerra opened 1 year ago

UltimaTerra commented 1 year ago

I am currently using Fedora 37, on an x86 machine. I tried with less programs opened and this still happened twice. I am running the latest version, so 0.15.0. It seems to

Here is what the terminal spits out:


QSocketNotifier: Can only be used with threads started with QThread
Fatal Python error: Segmentation fault

Current thread 0x00007f3c74bae740 (most recent call first):
  File "/usr/share/manuskript/manuskript/main.py", line 246 in launch
  File "/usr/share/manuskript/manuskript/main.py", line 312 in run
  File "/usr/bin/manuskript", line 30 in <module>

Extension modules: PyQt5.QtCore, PyQt5.QtGui, PyQt5.QtWidgets, PyQt5.QtNetwork, PyQt5.QtQml, PyQt5.QtBluetooth, PyQt5.QtDBus, PyQt5.QtDesigner, PyQt5.QtHelp, PyQt5.QtMultimedia, PyQt5.QtMultimediaWidgets, PyQt5.QtNfc, PyQt5.QtOpenGL, PyQt5.QtPositioning, PyQt5.QtLocation, PyQt5.QtPrintSupport, PyQt5.QtQuick, PyQt5.QtQuickWidgets, PyQt5.QtSensors, PyQt5.QtSerialPort, PyQt5.QtSql, PyQt5.QtSvg, PyQt5.QtTest, PyQt5.QtWebChannel, PyQt5.QtWebKit, PyQt5.QtWebKitWidgets, PyQt5.QtWebSockets, PyQt5.QtX11Extras, PyQt5.QtXml, PyQt5.QtXmlPatterns, lxml._elementpath, lxml.etree (total: 32)
Segmentation fault (core dumped)

This also happened very quickly, after about a few minutes of opening the program either through terminal or through a gui shortcut. If you need more information, let me know I am new to github but not so much to programming.

TheJackiMonster commented 1 year ago

It's likely this is caused by your theme. Some Qt themes can cause segmentation faults. I'd recommend switching theme or disabling it for the application.

UltimaTerra commented 1 year ago

Late, but this did fix my issue. But just because I am a bit paranoid, I am doing backups for plain text in Libre Office.

Not related, but if I wanted to contribute and build off a fork, is there any guidelines or suggestions i can use to start? Or Will I need to ask somewhere else? (This can be closed after, but for the record I just disabled my theme, works fine now.)

TheJackiMonster commented 1 year ago

You can just fork this repository and open pull requests when you want to contribute your changes. You are also free to pick whether you want to improve the current Qt version or develop on the newer GTK version which is still in early development on a separate branch.

TheJackiMonster commented 1 year ago

But if you worry about not meeting guidelines. I've given some feedback here: https://github.com/olivierkes/manuskript/pull/1113#issuecomment-1416031527

However I'm more concerned with clean code in the GTK branch than on the main branch using Qt. The code with Qt is already a mess. ^^'

xahodo commented 1 year ago

So, where can we find the gtk rewrite?

TheJackiMonster commented 1 year ago

It's here on Github in the gtk branch.

TheShadowOfHassen commented 1 year ago

@xahodo The Gtk port isn't a working version, however. You can test it though, you could also try out my two PRS and see if they have any issues.

https://github.com/olivierkes/manuskript/pull/1153

https://github.com/olivierkes/manuskript/pull/1113