olivierkes / manuskript

A open-source tool for writers
http://www.theologeek.ch/manuskript
GNU General Public License v3.0
1.71k stars 226 forks source link

Missing Pages with Version 0.16.0 #1248

Closed siliconserf closed 6 months ago

siliconserf commented 6 months ago

I tried out Version 0.16.0 on an existing project under Windows 11. I unpacked the installation into a new program fold to avoid cross version issues. The project loads with an interesting variation of what 0.15.0 shows. More important is what is missing. Chapter folders show Properties, Notes, etc.. But the file for each document that show in Outline and Edit that should be present in each chapter fold shows only the Properties content that should be there. Nothing else in the file shows up. And none of the color settings show either. If I close the project it closes off properly, and since I made no changes to any file, no date stamps change either. Changing back to 0.15.0 the project opens up with everything that is supposed to be there present. Text, Property, Notes, etc. as they should be.

2023-12-11_20-46-25_manuskript#47140.log

TheJackiMonster commented 6 months ago

Looks like you run into the same exception during save action as described in issue #1247.

TheJackiMonster commented 6 months ago

I've implemented a few patches to address path inconsistencies on Windows as well as newline characters while reading files. We changed the newline character to be always \n to make projects more cross-compatible. However now it is only reading content with \n on Windows which is not the default.

So I changed the behavior from detecting newline characters automatically while reading and writing always with \n. Also the exception should be fixed as well.

You can try the build from here: https://github.com/olivierkes/manuskript/actions/runs/7183624913

siliconserf commented 6 months ago

All seems to be as it should be. Nice fix.

On Tue, Dec 12, 2023 at 7:33 AM Tobias Frisch @.***> wrote:

I've implemented a few patches to address path inconsistencies on Windows as well as newline characters while reading files. We changed the newline character to be always \n to make projects more cross-compatible. However now it is only reading content with \n on Windows which is not the default.

So I changed the behavior from detecting newline characters automatically while reading and writing always with \n. Also the exception should be fixed as well.

You can try the build from here: https://github.com/olivierkes/manuskript/actions/runs/7183624913

— Reply to this email directly, view it on GitHub https://github.com/olivierkes/manuskript/issues/1248#issuecomment-1852277347, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHVW6FROQH7GNMYP6GT6IYLYJB2NPAVCNFSM6AAAAABAQ3CVW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJSGI3TOMZUG4 . You are receiving this because you authored the thread.Message ID: @.***>

-- "Everyone is entitled to his own opinion, but not his own facts." - Daniel Moynihan