search

olivierkes / manuskript

A open-source tool for writers
http://www.theologeek.ch/manuskript
GNU General Public License v3.0
1.7k stars 226 forks source link

grammar tools #1261

Open Reaper10 opened 6 months ago

Reaper10 commented 6 months ago

will you built in the Language Tool https://github.com/jxmorris12/language_tool_python one day?

FastusNumen commented 6 months ago

You should be able to see it in Tools if you have already installed it and if you use Manuskript's source code. Here's the wiki link: https://github.com/olivierkes/manuskript/wiki/Adding-a-Spellcheck-Language-Dictionary-to-Manuskript

It doesn't work for me, as you can see from issue #1252, but you can try it out and see how it goes for you.

If you're using the binary(.exe and others), there are some grammar checkers built-in, but they slowed down the program, so I never used them. I'm not sure if, or when, they'll add LanguageTool to it.

TheJackiMonster commented 6 months ago

Language Tool can already be used when the required python package is installed and Java which is required to locally run Language Tool. I assume most problem for users is that Windows makes it quite difficult to manage python packages and applications easily. But if you install/run Manuskript from source, it should be reasonable to get it working. However it's easier on any Linux distribution I assume. Because you can even install the packages via distributions own package management in some cases.

Reaper10 commented 5 months ago

Language Tool can already be used when the required python package is installed and Java which is required to locally run Language Tool. I assume most problem for users is that Windows makes it quite difficult to manage python packages and applications easily. But if you install/run Manuskript from source, it should be reasonable to get it working. However it's easier on any Linux distribution I assume. Because you can even install the packages via distributions own package management in some cases.

could you built in to Manuskript ? It would help people like me who don't code and on widows and latter when Manuskript is on mobile os .

TheJackiMonster commented 5 months ago

@Reaper10 As said the problem is mostly Windows. On a Linux distribution you basically install Manuskript, install Language Tool and it works.

On Windows it might be one of many issues. A user might not have LanguageTool installed. They might not have Java installed. There's no easy way to put everything into one huge binary and expect it to work.

Reaper10 commented 5 months ago

@TheJackiMonster should I just close this being that it's too hard to do?

TheJackiMonster commented 5 months ago

Idk. It's not impossible. The question is whether it's worth looking into it currently. It's definitely complicated from my understanding and comes with downsides. We already have a lot bigger binary for Windows than on the other options because PyInstaller squashes a lot of libraries into it which aren't even necessary (mostly from Qt).

Long term when using Gtk instead of Qt, I think it might be reasonable to switch from using PyInstaller to run Manuskript on Windows as Linux application. If we would do that, things like LanguageTool wouldn't be such an issue because we could completely avoid shipping all necessary parts inside the binary.

Problem is that I'm not sure whether that is a valid option already. I think Windows 11 ships WSL implicitly (which is required to run Linux applications on Windows) and Windows 12 will likely follow. But currently I assume we can't require people on Windows 10 to setup WSL manually.

Reaper10 commented 5 months ago

Idk. It's not impossible. The question is whether it's worth looking into it currently. It's definitely complicated from my understanding and comes with downsides. We already have a lot bigger binary for Windows than on the other options because PyInstaller squashes a lot of libraries into it which aren't even necessary (mostly from Qt).

Long term when using Gtk instead of Qt, I think it might be reasonable to switch from using PyInstaller to run Manuskript on Windows as Linux application. If we would do that, things like LanguageTool wouldn't be such an issue because we could completely avoid shipping all necessary parts inside the binary.

Problem is that I'm not sure whether that is a valid option already. I think Windows 11 ships WSL implicitly (which is required to run Linux applications on Windows) and Windows 12 will likely follow. But currently I assume we can't require people on Windows 10 to setup WSL manually.

go with wsl is isn't the best way to go it's real slow native app is best way to go.

TheJackiMonster commented 5 months ago

We are using Python, lol. As if performance would matter that much. Also in benchmarks WSL isn't much behind either. Graphics acceleration is certainly good enough for word processing software.

So overall it's a question of maintenance burden. Having one Linux binary to run across the board on all systems is much easier to test. Additionally debugging would be easier because of less inconsistencies. Every year there's at least one bug related to Windows being a snowflake.

Therefore I don't see why we wouldn't use WSL in the future except of compatibility. So it mostly depends on Microsoft shutting down support for older Windows versions in my opinion.

Reaper10 commented 5 months ago

We are using Python, lol. As if performance would matter that much. Also in benchmarks WSL isn't much behind either. Graphics acceleration is certainly good enough for word processing software.

So overall it's a question of maintenance burden. Having one Linux binary to run across the board on all systems is much easier to test. Additionally debugging would be easier because of less inconsistencies. Every year there's at least one bug related to Windows being a snowflake.

Therefore I don't see why we wouldn't use WSL in the future except of compatibility. So it mostly depends on Microsoft shutting down support for older Windows versions in my opinion.

ok I unferstand it easer but not everyone knows how or wants to or can (oler pcs) use WSL

TheJackiMonster commented 5 months ago

If it comes, everything will be automatic. Comparable to Proton/Wine under Linux to run Windows binaries. I wouldn't consider it if Microsoft wouldn't kill off support for older Windows versions that easily. Because afaik Windows 10 and below don't come with implicit WSL support, requiring manual setup.

But as soon as there's only Windows 11 and higher supported (after year 2025), I don't see why it would make sense to not utilize it. Until then it will certainly be a better and more reliable option than PyInstaller. Binaries will be consistent across the board, making it easier to debug. Also this might solve the issue of antivirus software false flagging the official binaries.

Reaper10 commented 5 months ago

If it comes, everything will be automatic. Comparable to Proton/Wine under Linux to run Windows binaries. I wouldn't consider it if Microsoft wouldn't kill off support for older Windows versions that easily. Because afaik Windows 10 and below don't come with implicit WSL support, requiring manual setup.

But as soon as there's only Windows 11 and higher supported (after year 2025), I don't see why it would make sense to not utilize it. Until then it will certainly be a better and more reliable option than PyInstaller. Binaries will be consistent across the board, making it easier to debug. Also this might solve the issue of antivirus software false flagging the official binaries.

ok if you added a plug in model you could add more stuff . Just think of a fix that can work right now without wsl.