search

olivierkes / manuskript

A open-source tool for writers
http://www.theologeek.ch/manuskript
GNU General Public License v3.0
1.77k stars 235 forks source link

[Feature request] Night mode/dark mode #388

Open lappet opened 6 years ago

lappet commented 6 years ago

A lot of editors and websites these days come with a night mode or a dark mode where the background text is not white in color. Can we get that please?

RiderExMachina commented 6 years ago

As a lover of dark themes I agree!

gedakc commented 6 years ago

Did you know that Manuskript already supports manually changing item colours?
See Edit -> Settings -> Views, and also Edit -> Settings -> Fullscreen sections.

To search through the existing issues raised for Manuskript you can add and subtract terms from the Filters. The steps to search all issues for the word "dark" are:

  1. Click on Issues in the Manuskript git page.
  2. Remove "is:open" from the Filters.
  3. Add "dark".
  4. Press Enter key.

This should create the following list of issues which contain the word "dark".

See issue 183 - Index card text almost invisible in dark themes for an example of how some users have configured dark themes.

Does that answer your question?

HorsaTheHetrisiniLord commented 6 years ago

No actually... I don't see exactly where it says how to configure a dark theme in that issue...

I'd much rather have an official dark theme instead of manually having to configure it.

gedakc commented 6 years ago

I believe the dark theme in the issue #183 mentioned above was selected at the desktop level.

For example in Kubuntu 16.04 I can select "Breeze Dark" under K -> Settings -> System Settings -> Workspace Theme -> Look And Feel.

kde-workspace-theme

Manuskript then uses the chosen workspace theme.

You can further refine the text editor colours using Manuskript's Edit -> Settings-> Views -> Text editor.

manuskript-text-editor-settings

gedakc commented 6 years ago

Comment from AlucardNoir copied from Manuskript 0.7.0 web site page:

I'm posting this here because I don't want to make a GitHub account and have yet another account and password to bog me down. In regards to the requested Dark Mode/Theme( https://github.com/olivierkes/manuskript/issues/388 ) while things might work in Linux like that, on Windows things are a lot different. Dark Mode was a joke before the last update and frankly still is somewhat of a joke even after the October update. For windows, at least at the present, the program must supply it's own dark theme. Hell, even MS Office doesn't use a windows flag to turn on the inbuilt dark themes it has, and that's an MS product - MS is bad at doing dark mode.

bobf32 commented 5 years ago

+1 for easy way to switch to dark mode. Manual theming only seems to go so far on Windows, i.e. the text editor.

Loving the product so far, great work.

zja203 commented 5 years ago

The thing is, the color-changing options don't seem to apply to the whole interface. I also tried to set a dark theme in Ubuntu, many of my apps switched to a dark theme, Manuskript did not. I really wish there was a dark theme because I use the black and green 'oldschool' theme for fullscreen editing, and switching back to the bright UI can be quite jarring.

This seems to be as close as I can get to an actual dark theme image

gedakc commented 5 years ago

Added How to Enable Dark Theme wiki entry.

corruleum commented 4 years ago

I also do not have a dark theme available in Manuskript, similar to zja203. Linux Mint 18.2, MATE, near as I can tell it uses GTK (GTK3?) for my system dark theme (not KDE Breeze Dark). All (but one) other programs I use either respect that or provide their own dark theme.

The two theme options I have available for Manuskript theme at all: Fusion (the default, and a light theme), or Windows. Neither of these appear to pay any attention to my system's dark theme.

zeth commented 4 years ago

A rather belated reply to @zja203, the issue is not Manuskript, it is Ubuntu not sending your theme options across to QT apps. The way I solved this, using the stock GNOME based Ubuntu 19.10:

sudo apt install qt5-style-plugins

Then in Manuskript's settings, I found that I had more than the two original options, I chose gtk2 and the application went suitably black and orange. As shown here:

settings

dmjohnsson23 commented 4 years ago

I just added some instructions that worked for me to get dark mode for Manuskript on Ubuntu/Gnome to the wiki page. I thought I'd point out here however, that (at least in my case) markdown headings in the text are unreadable in dark mode due to the dark blue font color used. I wasn't able to find a way to change that.

zeth commented 4 years ago

Interesting, using the gtk2 theme you get them in a kind of pink/salmon colour. salmon

zeth commented 4 years ago

When I use the adwaita-qt, they seem readable on my screen in blue.

adwaita

zeth commented 4 years ago

Okay, I have tried lots and lots themes for dark mode on Ubuntu and the one that doesn't seg fault (yet) and has no major visual drawbacks is called kvantum.

sudo apt install qt5-style-kvantum qt5-style-kvantum-themes

Then choose kvantum in Manuskript. nice

zeth commented 4 years ago

For the themes that crash, I got out gdb and tried to figure out what is happening but I fear the problems are in QT or with the themes themselves. I couldn't find anything that the Manuskript code is doing wrong. However, I am not a QT expert so your mileage may vary. I have found one dark theme that works (so far) and so I am happy.

nachtvlinder commented 3 years ago

Odd thing though, kvantum doesn't show the editor in night mode. whooptie. Would be so awesome if I could load that solarized-dark theme I like to use in some of my code editing environments ^^ Meantime, tweaks seem to work in a way. Edit: changing the font to certain font types changes the editor to night mode, Like seems to be the UKWM or URW ones, but I didn't do a full scale test because NaNoWriMo is on and I better get writing instead, haha.

zeth commented 3 years ago

Odd thing though, kvantum doesn't show the editor in night mode. whooptie.

Yes sorry, that's the way I like it. The text of my book is black on white but the program is dark. That way I can focus on my text and let the hard work of the Manuskript devs disappear into the background.

AlanDunaway commented 1 year ago

A rather belated reply to @zja203, the issue is not Manuskript, it is Ubuntu not sending your theme options across to QT apps. The way I solved this, using the stock GNOME based Ubuntu 19.10:

sudo apt install qt5-style-plugins

Then in Manuskript's settings, I found that I had more than the two original options, I chose gtk2 and the application went suitably black and orange. As shown here:

settings

As soon as I select gtk, Manuskript crashes on 22.04.