olivierkes / manuskript

A open-source tool for writers
http://www.theologeek.ch/manuskript
GNU General Public License v3.0
1.79k stars 236 forks source link

Feature Request: Add Dan Harmon's Story Circle to Plots #782

Open Gryphon324 opened 4 years ago

Gryphon324 commented 4 years ago

I enjoy the option to use the different story plotting types in the Meta column of the Plots section. I see that you have the Hero's Journey plot points. I would like to see a similar option for Dan Harmon's Story Circle. The points of the circle be 1. You, 2. Need, 3. Go, 4. Search, 5. Find, 6. Take, 7. Return, 8. Changed. If there is a way that I can add it myself via configuration files, I would gladly do it if I had instructions on how to do it.

ptoche commented 4 years ago

Looks like you can add your own dictionary here:

https://raw.githubusercontent.com/olivierkes/manuskript/4ff84d328d9bde98fc16de0e39c1786e3b44a436/manuskript/ui/views/plotDelegate.py

following the model of:

        self.tr("Hero's journey"): [
            self.tr("Ordinary world"),
            self.tr("Call to adventure"),
            self.tr("Refusal of the call"),
            self.tr("Meeting with mentor"),
            self.tr("Crossing the Threshold"),
            self.tr("Tests"),
            self.tr("Approach"),
            self.tr("Abyss"),
            self.tr("Reward / Revelation"),
            self.tr("Transformation"),
            self.tr("Atonement"),
            self.tr("Return"),
        ],

UNTESTED. Let us know!

Gryphon324 commented 4 years ago

Where do I find that file in Linux?

Regards Darryl Perry

On Sat, Jun 13, 2020 at 3:28 PM, Patrick Tochenotifications@github.com wrote:

Looks like you can add your own dictionary here:

https://raw.githubusercontent.com/olivierkes/manuskript/4ff84d328d9bde98fc16de0e39c1786e3b44a436/manuskript/ui/views/plotDelegate.py

following the model of: self.tr("Hero's journey"): [ self.tr("Ordinary world"), self.tr("Call to adventure"), self.tr("Refusal of the call"), self.tr("Meeting with mentor"), self.tr("Crossing the Threshold"), self.tr("Tests"), self.tr("Approach"), self.tr("Abyss"), self.tr("Reward / Revelation"), self.tr("Transformation"), self.tr("Atonement"), self.tr("Return"), ],

Let us know!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

ptoche commented 4 years ago

You would clone this repository, edit your files, re-build the app...

Not sure if modifying the file in-place, if it's available, would work. Worth a try. Just use a search/find tool for file plotDelegate.py anywhere near where your apps get installed (users/op or whatever it's called these days).

siliconserf commented 4 years ago

The file doesn't appear in the normal installation. I did try out simply adding an array defined with my take on Harmon points in plotDelegate.py and it works fine. At least the test project saves and reloads without complaint. Any consensus as to whether to add this and what the menu points should be?

Harmon Circle Manuskript Try

Gryphon324 commented 4 years ago

Thank you. I found the file in /usr/share/manuskript/manuskript/ui/views. I was able to add Story Circle and Save the Cat 15 beats. So my question is, will this file be overwritten during any upgrades? -Regards,  Darryl Perry

On Tuesday, June 16, 2020, 01:54:30 PM CDT, siliconserf <notifications@github.com> wrote:  

The file doesn't appear in the normal installation. I did try out simply adding an array defined with my take on Harmon points in plotDelegate.py and it works fine. At least the test project saves and reloads without complaint. Any consensus as to whether to add this and what the menu points should be?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

siliconserf commented 4 years ago

As I understand it, your change has to be made part of the working version file set. Otherwise the next time you download the latest working version, the file involved gets overwritten. You need a pull request and submitting your new file version. I doubt there will be any objections as the changes you're suggesting affect no other code and people can ignore the new options.

On Tue, Jun 16, 2020 at 12:02 PM Darryl P notifications@github.com wrote:

Thank you. I found the file in /usr/share/manuskript/manuskript/ui/views. I was able to add Story Circle and Save the Cat 15 beats. So my question is, will this file be overwritten during any upgrades? -Regards, Darryl Perry

On Tuesday, June 16, 2020, 01:54:30 PM CDT, siliconserf < notifications@github.com> wrote:

The file doesn't appear in the normal installation. I did try out simply adding an array defined with my take on Harmon points in plotDelegate.py and it works fine. At least the test project saves and reloads without complaint. Any consensus as to whether to add this and what the menu points should be?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/olivierkes/manuskript/issues/782#issuecomment-644954129, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHVW6FQNTI3NDI3BTU7LWW3RW66T5ANCNFSM4N4VX6VQ .

-- Ceterum censeo, delenda est Trumpo

TheJackiMonster commented 3 years ago

Yes, opening a pull request with the changes would be good, so it can be merged for the next release potentially.