Nu Html Checker: Improve Html Quality

throwaway-d commented 1 year ago

https://validator.w3.org/nu/?doc=https%3A%2F%2Fkeepachangelog.com%2F

About lang attribute: https://dequeuniversity.com/rules/axe/4.4/html-has-lang
About trailing slashes: https://github.com/validator/validator/wiki/Markup-%C2%BB-Void-elements

olivierlacan commented 1 year ago

The W3 tools doesn't follow redirects, so virtually none of this is useful:

<html>
<head><title>301 Moved Permanently</title></head>
<body>
<center><h1>301 Moved Permanently</h1></center>
<hr><center>nginx</center>
</body>
</html>

You have to feed it final URLs from resolved 301s: https://validator.w3.org/nu/?doc=https%3A%2F%2Fkeepachangelog.com%2Fen%2F1.1.0%2F

99% of the errors shown pertain to aria_hidden being used on anchor tags for headers, which we do indeed not want to put in the document accessibility tree since they'd be a huge pain for assistive devices.

throwaway-d commented 1 year ago

What about this though?

olivierlacan commented 1 year ago

Fixed the warnings, trailing slash issue is a wont fix since this is Haml-generated and not a concern. Won't fix that.

Thanks.

throwaway-d commented 1 year ago

Thank you for fixing them. I also have found some other things:

olivierlacan / keep-a-changelog

Nu Html Checker: Improve Html Quality #453