"Force removal" should abort early

oliviertassinari / babel-plugin-transform-react-remove-prop-types

Remove unnecessary React propTypes from the production build. :balloon:

MIT License

897 stars 61 forks source link

"Force removal" should abort early #123

Closed oliviertassinari closed 7 years ago

oliviertassinari commented 7 years ago

@bnjbvr #122 is a great PR! Thanks for opening in the first place. I wish you would have accepted maintainer to have write access to your branch in order to make changes but you didn't. I'm opening this new PR to remove the defensive code in src/remove.js. I would rather cut the problem at the root than later on by chance.

oliviertassinari commented 7 years ago

For an obscure reason, we have lost the author after merging this PR. I have pushed force 15901b32e19ef500bd7e2fbbdcb0ca147ff95fbf to get it back.

bnjbvr commented 7 years ago

Thanks! Now I get what this "allow maintainer edits" checkbox means 👍 Thanks for merging and publishing a new version!