search

oliviertassinari / babel-plugin-transform-react-remove-prop-types

Remove unnecessary React propTypes from the production build. :balloon:
MIT License
897 stars 61 forks source link

Include babel core as a peer dependency #165

Closed vikr01 closed 5 years ago

vikr01 commented 5 years ago

Since @babel/core is needed to use this plugin, it's good to include it as a peer dependency. (I followed the same way babel does it.)

It's also a good idea to keep that for anyone unsure whether this plugin supports babel 6 or babel 7.

oliviertassinari commented 5 years ago

@vikr01 What makes you think we depend on @babel/core? We are compatible with babel 7 and 6.

I followed the same way babel does it.

I think that Babel is going to because that have a hard import on it: https://github.com/babel/babel/blob/5fa3628506f381b8185591eae70f473b8c0bddbd/packages/babel-plugin-external-helpers/src/index.js#L2 I'm closing for now.

vikr01 commented 5 years ago

@oliviertassinari I saw all babel devDependencies were v7, which led me to believe this package only supports v7. If it's supposed to work for v6 as well, shouldn't that still be tested?

oliviertassinari commented 5 years ago

It should be working but it's not something we maintain. It might break or is already broken. I don't know. Maybe it will keep working with Babel v8.