search

oliviertassinari / babel-plugin-transform-react-remove-prop-types

Remove unnecessary React propTypes from the production build. :balloon:
MIT License
897 stars 61 forks source link

safer type checking #179

Closed tquetano-netflix closed 5 years ago

tquetano-netflix commented 5 years ago

Check for the existence of node.property before comparing node.property.name

Fixes #178

lencioni commented 5 years ago

Thanks for the fix! Can you please add a test that would have caught this?

oliviertassinari commented 5 years ago

Yes, can we add a test so we don't break it again in the future?

tquetano-netflix commented 5 years ago

Alright I'll try to recreate ... this was caught by our crazy build system with a lot of nested stuff. Give me a few.

tquetano-netflix commented 5 years ago

Sorry to be pestilent, but now that the fix has tests and is approved and all that jazz ... is there anything blocking its release? We'd like to incorporate this into our build because it will have immediate tangible gains. :smiley_cat:

oliviertassinari commented 5 years ago

@tquetano-netflix Well done! I'm releasing a patch :).