search

oliviertassinari / serviceworker-webpack-plugin

Simplifies creation of a service worker to serve your webpack bundles. :recycle:
https://oliviertassinari.github.io/serviceworker-webpack-plugin/
MIT License
458 stars 76 forks source link

Asset list should include source maps #44

Open rezonant opened 7 years ago

rezonant commented 7 years ago

Looks like the asset list provided by this plugin doesn't include generated source maps. I also noticed the manifest generated by https://github.com/arthurbergmz/webpack-pwa-manifest does not get included.

woutervanvliet commented 6 years ago

You can probably include sourceMaps by adding a transformOptions function, that defines what data ends up in your ServiceWorker code. But only if you promise you won't cache sourcemap files in a production build ;-)

Tbh, I'm not sure if it's good practice to cache the manifest - but it shouldn't be impossible. If the problem still exists, could you provide a minimal repo to reproduce the problem?