search

oliviertassinari / serviceworker-webpack-plugin

Simplifies creation of a service worker to serve your webpack bundles. :recycle:
https://oliviertassinari.github.io/serviceworker-webpack-plugin/
MIT License
458 stars 76 forks source link

postinstall script requires yarn #82

Closed timdouglas closed 6 years ago

timdouglas commented 6 years ago

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

browser:
browser version: 
operating system: osx yosemite
webpack version: 4.12.0

Repro steps.

npm install on a system without yarn installed fails

npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! serviceworker-webpack-plugin@1.0.0 postinstall: `(cd ./test/webpack3; yarn install)`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the serviceworker-webpack-plugin@1.0.0 postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
woutervanvliet commented 6 years ago

Sorry about that, that task should not have been in the released version.

Fixed in 1.0.1