oliyh / kamera

UI testing via image comparison and devcards
89 stars 7 forks source link

Better error when chrome doesn't start #36

Open AndreaCrotti opened 2 years ago

AndreaCrotti commented 2 years ago

I banged my head against the wall for a while trying to understand what was wrong, and the error I had was related a timeout trying to connect to the remote debugging port.

It turned out that the problem was simply that I was running as root, and the no-sandbox option was not actually passed in. And if I actually tried to run chrome with the same arguments as root it would have just failed straight away. Instead, it was just waiting for the process to come back and eventually timing out, which made it very hard to debug.

So ideally it should maybe just terminate if the chrome process can't even be started, and potentially for extra validation it could check if the UID=0, which would always require the --no-sandbox flag.