search

oliyh / martian

The HTTP abstraction library for Clojure/script, supporting OpenAPI, Swagger, Schema, re-frame and more
MIT License
529 stars 44 forks source link

Add support for the :plus-json option to bootstrap-openapi. #144

Closed bombaywalla closed 2 years ago

bombaywalla commented 2 years ago

This adds encoders and decoders for all content types of the form application/vnd.foo.bar+json that are found in the OpenAPI spec.

Should address #143

bombaywalla commented 2 years ago

Sorry. Commit 25e9314 had an error where I accidentally overwrote your recent change about expanding refs in parameters. Commit 10c128c reverts that accidental change.

oliyh commented 2 years ago

Hi,

Given the complexity of the code and what I consider to be a slightly esoteric API that creates the use case, I think coping with these content types is best done by the user with their own serialisation interceptors replacing or in addition to the martian ones. Hopefully there is plenty of code in martian that can be reused to help with this.

I appreciate your efforts here and in the other work you've done, so thank you for that but apologies I don't think this is a good fit for martian.

Thanks

bombaywalla commented 2 years ago

Okay. Fair enough. I can easily keep it outside of martian.