search

oliyh / martian

The HTTP abstraction library for Clojure/script, supporting OpenAPI, Swagger, Schema, re-frame and more
MIT License
525 stars 42 forks source link

Babashka support #165

Closed borkdude closed 1 year ago

borkdude commented 1 year ago

This PR adds both babashka support for the core module and support for babashka.http-client.

borkdude commented 1 year ago

@oliyh I'm sure you will have some feedback and request for changes, let me know.

The frankiesardo/linked dependency is no longer needed, but I didn't know if you were alright with me removing it.

oliyh commented 1 year ago

Hi @borkdude thanks for the PR. I've replied to most of the comments you left yourself, and will have a more detailed look through the rest of the code shortly but it looks good after a quick skim.

borkdude commented 1 year ago

@oliyh OK, processed your feedback now.

oliyh commented 1 year ago

Thanks @borkdude I thought there was an opportunity to be more concise but as you say bb will take the clj option, and I also noticed that the cljs branch wasn't identical either, so I think what you have is correct.

borkdude commented 1 year ago

Are the failing tests of any concern?

oliyh commented 1 year ago

The failing tests are because I lost https://pedestal-api.herokuapp.com when heroku effectively ended their free tier, and I haven't found time to deploy it anywhere else yet, so nothing to worry about here.

oliyh commented 1 year ago

Thanks for this!

borkdude commented 1 year ago

Amazing, thank YOU!