oliyh / martian

The HTTP abstraction library for Clojure/script, supporting OpenAPI, Swagger, Schema, re-frame and more
MIT License
525 stars 42 forks source link

Make re-frame module .cljc? #66

Open vemv opened 5 years ago

vemv commented 5 years ago

Hi there,

interesting library!

I noticed the re-frame module is .cljs, while re-frame is a .cljc library. At a glance, looks like the port would be easy.

Thanks - V

oliyh commented 5 years ago

Hi,

Yes, it could be ported with some interop namespaces for cljs and clj. Would you have a use for it though? The re-frame bindings are mostly for state management which on a Clojure system you would normally achieve using component / mount / other similar libraries.

Cheers

vemv commented 3 years ago

Hi, sorry I never replied to this.

I try to use .cljc whenever possible. I share this article's sentiment:

Is all your business logic available cross-platform?

https://widdindustries.com/cross-platform/

tldr, .cljc can force a more functional style (or at least force the use of defprotocols, which can be seen as a poor man's functional style)

awb99 commented 2 years ago

If my mind does not fool me, then I have seen an implementation of reframe for clj in the past. Wad only alpha. But interesting for setvet side workflows.