oliyh / re-graph

A graphql client for clojurescript and clojure
460 stars 39 forks source link

Parsing exceptions from cljs-http are unhandled #52

Closed suryagaddipati closed 4 years ago

suryagaddipati commented 4 years ago

image

I tried putting a try catch block around (a/<! response-chan)] but that error seems to be happening in another async block in the cljs-http library so it doesn't get caught in the try block in my code.

Not sure how can this can be handled in this library ( seems like a bug in cljs-http library), i am opening an issue here to see if i am missing something obvious.

oliyh commented 4 years ago

Hi,

I've had a quick look and can't see anything obvious you can do within the existing API - even if you passed a channel into cljs-http I think it would still blow up like this before it would pipe on to the provided channel.

Have you raised an issue in cljs-http?

Cheers

suryagaddipati commented 4 years ago

Have you raised an issue in cljs-http?

No not yet. Wanted to check here first.

Yes I agree that nothing can be done here atm. I will raise an issue in cljs-http.

thank you.