search

oliyh / re-graph

A graphql client for clojurescript and clojure
460 stars 39 forks source link

Fix queries without ID in cljs (see #77) #78

Closed oliyh closed 1 year ago

oliyh commented 3 years ago

See #77

hipitihop commented 1 year ago

I have found while converting to new 0.2.0 API if I provide an :id the callback fails to be dispatched. No hint in console errors. I have not investigated deeper sorry. If I remove the :id, then all works as expected. This is likely related ?

oliyh commented 1 year ago

Hi,

I've added a test which passes, see https://github.com/oliyh/re-graph/commit/abffdc040461ffe1cac540d2dfce987127707afe The behaviour seems correct to me.

The related PR #77 was before the 0.2 refactor, so I should have closed this issue with 0.2.0, I will leave it open for you to use though if you're able to provide any more info?

Thanks

hipitihop commented 1 year ago

@oliyh Thanks, I have re-tested a couple of queries with IDs and they indeed seem to work fine. Problem must have been on my side during conversion to the new API. Appreciate the response, feel free to close.

oliyh commented 1 year ago

Thanks for the update @hipitihop