oliyh / re-graph

A graphql client for clojurescript and clojure
460 stars 39 forks source link

Websocket messages get dropped/ignored when last? is true #91

Closed vincentjames501 closed 1 year ago

vincentjames501 commented 1 year ago

Right now in re-graph.interop in lines:

(fn [_ws message _last?]
  (on-message (str message)))

It's ignoring the _last? parameter. In my case Hasura is chunking a few kb of json back which results in a partial message (i.e. not parseable yet). re-graph should accumulate the messages until _last? is true and then dispatch the on-message callback.

oliyh commented 1 year ago

Thanks for your contribution!