search

oliyh / slacky

Memes as a Slack Service
33 stars 3 forks source link

Add some memes #21

Closed JesseTG closed 8 years ago

JesseTG commented 8 years ago

However, I can't actually tell Clojure from a hole in the ground. So, no guarantee that the syntax is correct.

Man, you should really section this part off to a data file or something.

oliyh commented 8 years ago

Thanks @JesseTG! The matching parsing pattern is quite tightly coupled to the function generating the strings that get used to create the meme, which prevents it being just data at the moment, but it is definitely something I would like to improve!

JesseTG commented 8 years ago

Sounds good to me. I like how quickly it was deployed. If I want a meme implemented, do you just want me to file an issue in the future?

oliyh commented 8 years ago

Up to you - there are some other changes which also need to be made which you may or may not be comfortable doing (see the commit which closed this issue). I'm happy to implement if you provide the general pattern and the template on memecaptain.

Deployment will generally be instant once the change is made and the build passes!

JesseTG commented 8 years ago

I can do the general pattern just fine. Hell, I'd contribute it directly if I actually knew Clojure.

I should pick a Lisp to learn over the summer.