search

olle / lz77-kit

Some LZ77 compression utilities for the handy hands-on developer in search for a few less bytes of I/O.
http://www.studiomediatech.com/projects/lz77-kit
MIT License
64 stars 23 forks source link

added c# porting of lz77 #2

Closed gitPhate closed 8 years ago

gitPhate commented 8 years ago

Hello, I added a C# porting of the LZ77 algorithm, as I ported the java implementation for a project of mine. My implementation works on bytes.

olle commented 8 years ago

Hi, looks great. I'd love to pull this into the repo.

How about adding a small test, though? Also, any pointers on how to get such tests also running with the Mono-SDK would be super.

Thanks!

gitPhate commented 8 years ago

I have to worry you about the performance, I'm currently working to make it quicker, and I'll add some tests. We'll stay in touch Il 04/nov/2015 10:39 PM, "Olle Törnström" notifications@github.com ha scritto:

Hi, looks great. I'd love to pull this into the repo.

How about adding a small test, though? Also, any pointers on how to get such tests also running with the Mono-SDK would be super.

Thanks!

— Reply to this email directly or view it on GitHub https://github.com/olle/lz77-kit/pull/2#issuecomment-153874601.

gitPhate commented 8 years ago

Updates: I found the issue, in these days I will make another pull request with the right class. As for the mono tests, I never used it but I think that the test methods are the same as visual studios. I will post them in the new pull request, but consider that I don't have pretty much time (I'm at work and I develop only when I have nothing else to do). I'll be in touch!

olle commented 8 years ago

Hi, sounds great. And regarding the tests/Mono - don't worry, it's all good.

I'll pull and merge when you're done. Thanks again!