olliw42 / mLRS-docu

Documentation for the mLRS project
GNU General Public License v3.0
35 stars 11 forks source link

r9 improvements #121

Closed jlpoltrack closed 9 months ago

jlpoltrack commented 9 months ago

To address: https://github.com/olliw42/mLRS-docu/issues/114

General notes:

olliw42 commented 9 months ago

very nice !!!

@brad112358 your input on this would be very much appreciated

the pictures are great but I think it's not as illustrative as it could be, with the embedding in bullet points as now. Maybe they both could be put ion one pic, to the left and right, with some annotation on the left and right part. Would slim it down and make the bullets supefluous. Just a thought.

jlpoltrack commented 9 months ago

the pictures are great but I think it's not as illustrative as it could be, with the embedding in bullet points as now. Maybe they both could be put ion one pic, to the left and right, with some annotation on the left and right part. Would slim it down and make the bullets supefluous. Just a thought.

Good point, added a new photo with annotations which replaces the clunky text.

olliw42 commented 9 months ago

much nicer :) I've fooled around with your latest pic (faking it)

dips

jlpoltrack commented 9 months ago

Dip switch annotations now in green for extra contrast :)

olliw42 commented 9 months ago

👍 👍 👍

let's hear @brad112358 for the elrs etc details

olliw42 commented 9 months ago

from my side lgtm

not sure what @brad112358 has to say, especially on teh ELRS stuff

brad112358 commented 9 months ago

Thanks for doing this! Updating this has been on my list of things to do for a while. I think the only item on my list that you didn't address here is the choice of esp32 modules. The document sort of suggests that the M5Stamp C3U Mate is the best choice, but when I wrote this, I didn't realize that the esp32 chips that support BT LE don't still support classic BT serial. The M5 Stamp Pico Mate can do both Bluetooth serial and WiFi so it may be a better choice for many new users in spite of needing a special serial adapter to program it. I've been meaning to add this info and add the photos of the M5Stamp Pico that I included in the Ardupilot documentation page.

olliw42 commented 9 months ago

that's a very good point indeed it needs to make better clear that not all ESP32 modules suitable for mlrs-wirelessbridge are also BT classic capable (it nowadays is probably fair to call these just a small subset), but that this is required for "easier" CLI access...

brad112358 commented 9 months ago

I think the newer ESP32 modules can still be used for CLI access, via telnet or a TCP terminal program when TCP is selected for the sketch. I tested a wifi terminal app on android, but telnet should also work fine on windows or linux or android. Just specify the matching port when starting telnet. (I still need to test telnet).

jlpoltrack commented 9 months ago

Expanded the section on how to use ESP32 + CLI.

brad112358 commented 9 months ago

It all looks good to me! I'll try to add a photo showing the connector on the M5 Stamp Pico Mate along with a link on flashing it at some point. It may also someday be possible to do serial via BLE 5.0, but I think work is required on the ground station side.

jlpoltrack commented 9 months ago

@brad112358 Alright to handle image update in separate PR?

@olliw42 If brad agrees to the above then I will merge.

brad112358 commented 9 months ago

@brad112358 Alright to handle image update in separate PR?

Yes. That's what I was trying to say. :)