search

olliw42 / mLRS-docu

Documentation for the mLRS project
GNU General Public License v3.0
35 stars 11 forks source link

Add a photo and more information on flashing and using the Pico Mate. #122

Closed brad112358 closed 8 months ago

brad112358 commented 9 months ago

This adds some additional info for users who might want to use Bluetooth to connect to their GCS.

jlpoltrack commented 9 months ago

Looks good - just a few small comments.

olliw42 commented 9 months ago

few further comnents

I find the pic confusing, as it has two pinheaders, and it's not easily obvious how it releates to the text. I also think the two pics could be combined. I thus grapped your photos and mangled them a bit and cooked up this as an indication:

m5

I also find the paragraphs need some reordering, they jump topics. I suggest swapping the 2nd and 3rd paragraphs, to have kind of virtual chapters on the C3U and the Pico (add real chapters and you'll see the order):

"The mLRS git repository includes an Arduino sketch ..." "Connecting the M5Stamp C3U or Pico Mate to the R9M is easy ..." "To install the sketch on the M5Stamp C3U Mate ..." "If you use the M5Stamp Pico Mate, ..." "Programming the Pico Mate is fairly easy ... "

brad112358 commented 9 months ago

Combining the photos helps reduce vertical space and I like the labels you added to the pictures! Lets use your version.

brad112358 commented 8 months ago

I also reordered the paragraphs as suggested. Any more comments on this PR?

jlpoltrack commented 8 months ago

I'm happy with the current state. @olliw42 do you have any more feedback?

olliw42 commented 8 months ago

I guess I would make some few changes as the flow of info is a bit rough but it's personal taste. If you guys are happy I'll be very happy too :)

jlpoltrack commented 8 months ago

Thanks, I will merge. One idea for future consideration may be to break the R9 page into two as it is very lengthy today, one for Tx hardware and one for Rx hardware.